Skip to content

Dot-sourced reference detection does not account for script blocks #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue Sep 8, 2016 · 1 comment
Closed

Dot-sourced reference detection does not account for script blocks #291

daviwil opened this issue Sep 8, 2016 · 1 comment
Labels
Issue-Bug A bug to squash.
Milestone
0.8.0

Comments

@daviwil
Copy link
Contributor

daviwil commented Sep 8, 2016

In PowerShell, it is valid syntax to dot-source a ScriptBlock. Our FindDotSourcedVisitor class does not account for this possibility and treats a dot-sourced ScriptBlock as a referenced script path. This currently does not cause a problem or crash but the behavior should still be fixed.

This issue was originally reported by @itzik-h on the vscode-powershell repo:

PowerShell/vscode-powershell#224 (comment)
@daviwil daviwil added the Issue-Bug A bug to squash. label Sep 8, 2016
@daviwil daviwil added this to the 0.7.3 milestone Sep 8, 2016
@daviwil
Copy link
Contributor Author

daviwil commented Sep 12, 2016

Now tracking this issue on the VS Code side over at PowerShell/vscode-powershell#171.

@daviwil daviwil modified the milestones: 0.7.3, 0.8.0 Nov 29, 2016
daviwil added a commit that referenced this issue Dec 9, 2016
@daviwil
Fix #291: Dot-source reference detection should ignore ScriptBlocks
09abdc8
@daviwil daviwil closed this as completed in 5c0ac2c Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug A bug to squash.
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@daviwil