Skip to content

Language server sometimes crashes then $ErrorActionPreference = "Stop" #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue May 17, 2016 · 1 comment
Closed

Language server sometimes crashes then $ErrorActionPreference = "Stop" #232

daviwil opened this issue May 17, 2016 · 1 comment
Labels
Issue-Bug A bug to squash.
Milestone
0.6.2

Comments

@daviwil
Copy link
Contributor

daviwil commented May 17, 2016

The language server sometimes crashes when gathering details about a command either for signature help or symbol hover when the user has set their $ErrorActionPreference to Stop. This will require handling the System.Management.Automation.ActionPreferenceStopException appropriately.

Original issue: PowerShell/vscode-powershell#187
@daviwil daviwil added the Issue-Bug A bug to squash. label May 17, 2016
@daviwil daviwil added this to the 0.6.2 milestone May 17, 2016
@daviwil
Copy link
Contributor Author

daviwil commented May 17, 2016

cc @fromthewoods

daviwil added a commit that referenced this issue May 17, 2016
@daviwil
Fix #232: Language server crashes when ErrorActionPreference is "Stop"
71144d8 
This change fixes an issue where the language server can sometimes crash
when the user has configured their $ErrorActionPreference variable to
"Stop" in the language server's session.  The fix is to refactor existing
code to use a common code path that handles RuntimeExceptions
appropriately.
daviwil added a commit that referenced this issue May 17, 2016
@daviwil
Fix #232: Language server crashes when ErrorActionPreference is "Stop"
e84e0ee 
This change fixes an issue where the language server can sometimes crash
when the user has configured their $ErrorActionPreference variable to
"Stop" in the language server's session.  The fix is to refactor existing
code to use a common code path that handles RuntimeExceptions
appropriately.
@daviwil daviwil modified the milestones: 0.7.0, 0.6.2 Aug 9, 2016
This was referenced Aug 9, 2016
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug A bug to squash.
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
1 participant
@daviwil