_mainRunspaceEngineIntrinsics null in OnPowerShellIdle

[dkattan]

I'm not sure why this is happening or if it is expected behavior but _mainRunspaceEngineIntrinsics is null (sometimes) in OnPowerShellIdle.

This appears to happen when I start a second instance of PSES from my calling application.

Adding a null check here feels like a bandaid. If I inspect the call stack I find at the beginning when PsesInternalHost.Run() is called, _mainRunspaceEngineIntrinsics is in fact being set to a proper value, so at some point there must be another instance of PsesInternalHost getting created that doesn't have this property initialized.

Is anyone else seeing this?

Call Stack

Microsoft.PowerShell.EditorServices.dll!Microsoft.PowerShell.EditorServices.Services.PowerShell.Host.PsesInternalHost.OnPowerShellIdle(System.Threading.CancellationToken idleCancellationToken) Line 778 C#
Microsoft.PowerShell.PSReadLine2.dll!Microsoft.PowerShell.PSConsoleReadLine.ReadKey() Unknown
Microsoft.PowerShell.PSReadLine2.dll!Microsoft.PowerShell.PSConsoleReadLine.InputLoop() Unknown
Microsoft.PowerShell.PSReadLine2.dll!Microsoft.PowerShell.PSConsoleReadLine.ReadLine(System.Management.Automation.Runspaces.Runspace runspace, System.Management.Automation.EngineIntrinsics engineIntrinsics, System.Threading.CancellationToken cancellationToken, bool? lastRunStatus) Unknown
Microsoft.PowerShell.EditorServices.dll!Microsoft.PowerShell.EditorServices.Services.PowerShell.Console.PsrlReadLine.InvokePSReadLine(System.Threading.CancellationToken cancellationToken) Line 58 C#
Microsoft.PowerShell.EditorServices.dll!Microsoft.PowerShell.EditorServices.Services.PowerShell.Execution.SynchronousDelegateTask.Run(System.Threading.CancellationToken cancellationToken) Line 68 C#
Microsoft.PowerShell.EditorServices.dll!Microsoft.PowerShell.EditorServices.Services.PowerShell.Execution.SynchronousTask.ExecuteSynchronously(System.Threading.CancellationToken executorCancellationToken) Line 92 C#
Microsoft.PowerShell.EditorServices.dll!Microsoft.PowerShell.EditorServices.Services.PowerShell.Execution.SynchronousTask.ExecuteAndGetResult(System.Threading.CancellationToken cancellationToken) Line 108 C#

[StevenBucher98]

Thanks @dkattan! what is the scenario where you need second instance of PSES?

[JustinGrote]

@StevenBucher98 within the same runspace seems unnecesary, but it certainly is common to have multiple PSES processes in vscode, for instance "Run in Temporary Integrated Console", not sure if this would be related (it shouldn't since it should be a completely separate process)

[dkattan]

Thanks @dkattan! what is the scenario where you need second instance of PSES?

I’m building a web based editor and I need to spawn an instance of PSES for each open editor in a browser.

I dug deeper and the problem appears to be that I was not shutting down PSES properly, so I Implemented the correct commands to PSES to get it to shutdown, but it didn’t because it never actually made it to the waitForShutdown method because it was waiting for the debugger to attach which will never happen because I haven’t implemented that and also may not ever because in my scenario I’m running in constrained language mode.

So the real fix here appears to be to implement an -LSPOnly switch similar to -DebugOnly

[andyleejordan]

@dkattan We resolved this by merging #1640 which allows you to avoid the deadlock waiting for the debugger to attach and so you're able to now fully shutdown PSES, right?

[dkattan]

@dkattan We resolved this by merging #1640 which allows you to avoid the deadlock waiting for the debugger to attach and so you're able to now fully shutdown PSES, right?

Yes, this is working as expected now. Thanks!