Show PSSA load exception

Author: andyleejordan

src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs

@@ -88,9 +88,9 @@ internal static string GetUniqueIdFromDiagnostic(Diagnostic diagnostic)
 
         private readonly WorkspaceService _workspaceService;
 
-        private readonly int _analysisDelayMillis;
+        private readonly int _analysisDelayMillis = 750;
 
-        private readonly ConcurrentDictionary<ScriptFile, CorrectionTableEntry> _mostRecentCorrectionsByFile;
+        private readonly ConcurrentDictionary<ScriptFile, CorrectionTableEntry> _mostRecentCorrectionsByFile = new();
 
         private Lazy<PssaCmdletAnalysisEngine> _analysisEngineLazy;
 
@@ -112,11 +112,8 @@ public AnalysisService(
             _languageServer = languageServer;
             _configurationService = configurationService;
             _workspaceService = workspaceService;
-            _analysisDelayMillis = 750;
-            _mostRecentCorrectionsByFile = new ConcurrentDictionary<ScriptFile, CorrectionTableEntry>();
             _analysisEngineLazy = new Lazy<PssaCmdletAnalysisEngine>(InstantiateAnalysisEngine);
             _pssaModulePath = Path.Combine(hostInfo.BundledModulePath, "PSScriptAnalyzer");
-            _pssaSettingsFilePath = null;
         }
 
         /// <summary>

src/PowerShellEditorServices/Services/Analysis/PssaCmdletAnalysisEngine.cs

@@ -71,19 +71,12 @@ public PssaCmdletAnalysisEngine Build(string pssaModulePath)
                 // RunspacePool takes care of queuing commands for us so we do not
                 // need to worry about executing concurrent commands
                 ILogger logger = _loggerFactory.CreateLogger<PssaCmdletAnalysisEngine>();
-                try
-                {
-                    logger.LogDebug("Creating PSScriptAnalyzer runspace with module at: '{Path}'", pssaModulePath);
-                    RunspacePool pssaRunspacePool = CreatePssaRunspacePool(pssaModulePath);
-                    PssaCmdletAnalysisEngine cmdletAnalysisEngine = new(logger, pssaRunspacePool, _rules, _settingsParameter);
-                    cmdletAnalysisEngine.LogAvailablePssaFeatures();
-                    return cmdletAnalysisEngine;
-                }
-                catch (Exception ex)
-                {
-                    logger.LogError(ex, "Unable to load PSScriptAnalyzer, disabling script analysis!");
-                    return null;
-                }
+
+                logger.LogDebug("Creating PSScriptAnalyzer runspace with module at: '{Path}'", pssaModulePath);
+                RunspacePool pssaRunspacePool = CreatePssaRunspacePool(pssaModulePath);
+                PssaCmdletAnalysisEngine cmdletAnalysisEngine = new(logger, pssaRunspacePool, _rules, _settingsParameter);
+                cmdletAnalysisEngine.LogAvailablePssaFeatures();
+                return cmdletAnalysisEngine;
             }
         }