Skip to content

Correction of roles and workflow #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2017
Merged

Correction of roles and workflow #81

merged 3 commits into from
Mar 24, 2017

Conversation

iSazonov
Copy link
Contributor

@iSazonov iSazonov commented Mar 17, 2017

Based on my first experience. 🐔


This change is Reviewable

@msftclas
Copy link

@iSazonov,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@joeyaiello
Copy link
Contributor

I owe you a review on this: the intent looks totally right, I appreciate you recognizing some of our gaps. I

f it's okay with you, I'll probably just push some of the language and terminology changes right into your branch.

@iSazonov
Copy link
Contributor Author

@joeyaiello
While working on a RFC I asked @SteveL-MSFT and here I only tried to reflect his answers about workflow as I understood him.
So feel free to make any changes.


Code work has not started/planned or not needed.
Code work has not started and is not planned or not needed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line is still difficult to understand 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

No one has begun implementing the RFC, and there are no current plans to implement the RFC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joeyaiello
Copy link
Contributor

@SteveL-MSFT can you merge this when you get a chance?

Also, as a heads up, @iSazonov, we decided in our last community call that we need to revise the process itself here, and we'll likely be switching to PR-based feedback rather than issue-based feedback. When I get around to that, I'd like to add you as a reviewer to make sure we're not missing any gaps in the "new" process (it shouldn't be that different, but we're hoping it simplifies some of the manual steps). Sound good?

@SteveL-MSFT SteveL-MSFT merged commit 66d0435 into PowerShell:master Mar 24, 2017
@iSazonov
Copy link
Contributor Author

@joeyaiello From the short post I don't understood that is "PR-based" so I just explain what I see.

The main problem is the low activity. We need more advertising the opportunity to discuss our RFCs.
Therefore, we need a single entry point for discussion.
Then we can publish it in the PowerShell PG blog team, MVP's blogs, and UserVoice. I suppose it will not be too burdensome for maintainers if we add this to the process.
Perhaps we should create a referencing Issue in PowerShell repo with label "RFC-Discussion" (blocked for posts creation).
To provide a single point of entry we need to strike a balance between the use of Issues and PRs. Maybe even use GitHub Projects.

We also have to consider what to do a feedback post much easier than a PR. If we will be "PR-based" only we may lost 99% feedback.
With regard to PR we need Howto with easy step-by-step - we should not assume that feedback will only be from coders, git and GitHub gurus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants