Tabs indentation is handled incorrectly

[Stanvy]

Issue Type: Bug

For Alman code formatting style, tabs indentation is handled incorrectly.
For example, the following code will have one space character in front of open brackets and "else" statement instead of tab:

while ($a) {
	if ($b) {
		$c = 1
	} else {
		$d = 2
	}
}

Extension version: 2020.3.0
VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:38:38.248Z)
OS version: Windows_NT x64 10.0.18363

[SydneyhSmith]

@Stanvy thanks for opening this issue, looks like your issue is the same as #1055 can you confirm if this is what you are experiencing?

[Stanvy]

In my opinion it's a different issue.

So, back to provided example...

Input:

while ($a) {
	if ($b) {
		$c = 1
	} else {
		$d = 2
	}
}

Output:

1. while ($a)
2. {
3. 	if ($b)
4.  {
5. 		$c = 1
6. 	}
7.  else
8.  {
9. 		$d = 2
10. 	}
11. }

Expected:

1. while ($a)
2. {
3. 	if ($b)
4. 	{
5. 		$c = 1
6. 	}
7. 	else
8. 	{
9. 		$d = 2
10. 	}
11. }

So in the "Output" string lines 4, 7 and 8 start with space, but should be with tab.

[bergmeister]

@Stanvy PSSA has never had complete support for tabs generally speaking. Although the UseConsistentIndentation rule has an option for using tabs instead of spaces, most of the rules rules do not have similar options and just have spaces hardcoded:

• PlaceOpenBrace:

  PSScriptAnalyzer/Rules/PlaceOpenBrace.cs

  Line 329 in 128a9a2

  return new String(' ', GetStartColumnNumberOfTokenLine(tokens, refTokenPos) - 1);

• PlaceCloseBrace:

  PSScriptAnalyzer/Rules/PlaceCloseBrace.cs

  Line 293 in 128a9a2

  return new String(' ', openBraceToken.Extent.StartColumnNumber - 1);

• AlignAssignment:

  PSScriptAnalyzer/Rules/AlignAssignmentStatement.cs

  Line 34 in 128a9a2

  private readonly char whitespaceChar = ' ';

  
  We could certainly look into adding it for all formatting rules and probably wrap up usage with a single VS-Code setting but it has never been a priority and the community hasn't upvoted the general tabs issue Invoke-Formatter: Tab Issue #1055, therefore closing this as a duplicate of PSSA not supporting tabs at the moment.
  May I ask why it is important for you to use tabs over spaces? Just philosophical or more useful when using certain tools?

[Stanvy]

I would say more as personal preference that I used to throughout the years.