Reduce verbosity of build script

Update to use Pester version 4.1.1
Change logic in appveyor to invoke pester only once

Author: JamesWTruher

README.md

@@ -129,7 +129,7 @@ For adding/removing resource strings in the `*.resx` files, it is recommended to
 #### Tests
 Pester-based ScriptAnalyzer Tests are located in `path/to/PSScriptAnalyzer/Tests` folder.
 
-* Ensure Pester 3.4 is installed on the machine
+* Ensure Pester 4.1.1 is installed on the machine
 * Copy `path/to/PSScriptAnalyzer/out/PSScriptAnalyzer` to a folder in `PSModulePath`
 * Go the Tests folder in your local repository
 * Run Engine Tests:

Tests/Engine/CustomizedRule.tests.ps1

@@ -106,7 +106,7 @@ Describe "Test importing correct customized rules" {
 		It "will show the custom rules when given a glob" {
 			# needs fixing for Linux
 			$expectedNumRules = 4
-			if ( ! $IsWindows )
+			if (!$IsWindows)
 			{
 				$expectedNumRules = 3
 			}
@@ -122,7 +122,7 @@ Describe "Test importing correct customized rules" {
 		It "will show the custom rules when given glob with recurse switch" {
 			# needs fixing for Linux
 			$expectedNumRules = 5
-			if (! $IsWindows )
+			if (!$IsWindows)
 			{
 				$expectedNumRules = 4
 			}

Tests/Engine/InvokeScriptAnalyzer.tests.ps1

@@ -470,7 +470,7 @@ Describe "Test -Fix Switch" {
 
     BeforeAll {
         $scriptName = "TestScriptWithFixableWarnings.ps1"
-        $testSource = join-path $PSScriptRoot ${scriptName}
+        $testSource = join-path $PSScriptRoot $scriptName
         $fixedScript = join-path $PSScriptRoot TestScriptWithFixableWarnings_AfterFix.ps1
         $expectedScriptContent = Get-Content $fixedScript -raw
         $testScript  = Join-Path $TESTDRIVE $scriptName

Tests/Engine/RuleSuppression.tests.ps1

@@ -106,7 +106,7 @@ function SuppressPwdParam()
     }
 
     Context "Rule suppression within DSC Configuration definition" {
-        It "Suppresses rule" -skip:((!$IsWindows) -or ($PSVersionTable.PSVersion -lt [Version]'5.0.0')) {
+        It "Suppresses rule" -skip:((!$IsWindows) -or ($PSVersionTable.PSVersion.Major -lt 5)) {
             $suppressedRule = Invoke-ScriptAnalyzer -ScriptDefinition $ruleSuppressionInConfiguration -SuppressedOnly
             $suppressedRule.Count | Should Be 1
         }

Tests/Rules/AlignAssignmentStatement.tests.ps1

@@ -66,7 +66,7 @@ $x = @{ }
     }
 
     Context "When assignment statements are in DSC Configuration" {
-        It "Should find violations when assignment statements are not aligned" -skip:($IsLinux -or $IsMacOS) {
+        It "Should find violations when assignment statements are not aligned" -skip:(!$IsWindows) {
             $def = @'
 Configuration MyDscConfiguration {
 

appveyor.yml

@@ -19,12 +19,12 @@ cache:
 install:
     - ps: nuget install platyPS -Version 0.9.0 -source https://www.powershellgallery.com/api/v2 -outputDirectory "$Env:ProgramFiles\WindowsPowerShell\Modules\." -ExcludeVersion
     - ps: |
-        $requiredPesterVersion = '3.4.0'
+        $requiredPesterVersion = '4.1.1'
         $pester = Get-Module Pester -ListAvailable | Where-Object { $_.Version -eq $requiredPesterVersion }
         $pester
         if ($null -eq $pester) # WMF 4 build does not have pester
         {
-            cinst -y pester --version $requiredPesterVersion
+            nuget install Pester -Version 4.1.1 -source https://www.powershellgallery.com/api/v2 -outputDirectory "$Env:ProgramFiles\WindowsPowerShell\Modules\." -ExcludeVersion
         }
     - ps: |
         # the legacy WMF4 image only has the old preview SDKs of dotnet
@@ -57,19 +57,15 @@ branches:
 test_script:
     - SET PATH=c:\Program Files\WindowsPowerShell\Modules\;%PATH%;
     - ps: |
-        copy "C:\projects\psscriptanalyzer\out\PSScriptAnalyzer" "$Env:ProgramFiles\WindowsPowerShell\Modules\" -Recurse -Force
-        $engineTestResultsFile = ".\EngineTestResults.xml"
+        copy-item "C:\projects\psscriptanalyzer\out\PSScriptAnalyzer" "$Env:ProgramFiles\WindowsPowerShell\Modules\" -Recurse -Force
+        $testResultsFile = ".\TestResults.xml"
         $ruleTestResultsFile = ".\RuleTestResults.xml"
-        $engineTestResults = Invoke-Pester -Script "C:\projects\psscriptanalyzer\Tests\Engine" -OutputFormat NUnitXml -OutputFile $engineTestResultsFile -PassThru
-        (New-Object 'System.Net.WebClient').UploadFile("https://ci.appveyor.com/api/testresults/nunit/$($env:APPVEYOR_JOB_ID)", (Resolve-Path $engineTestResultsFile))
+        $testScripts = "C:\projects\psscriptanalyzer\Tests\Engine","C:\projects\psscriptanalyzer\Tests\Rules"
+        $testResults = Invoke-Pester -Script $testScripts -OutputFormat NUnitXml -OutputFile $testResultsFile -PassThru
+        (New-Object 'System.Net.WebClient').UploadFile("https://ci.appveyor.com/api/testresults/nunit/$($env:APPVEYOR_JOB_ID)", (Resolve-Path $testResultsFile))
         if ($engineTestResults.FailedCount -gt 0) {
             throw "$($engineTestResults.FailedCount) tests failed."
         }
-        $ruleTestResults = Invoke-Pester -Script "C:\projects\psscriptanalyzer\Tests\Rules" -OutputFormat NUnitXml -OutputFile $ruleTestResultsFile -PassThru
-        (New-Object 'System.Net.WebClient').UploadFile("https://ci.appveyor.com/api/testresults/nunit/$($env:APPVEYOR_JOB_ID)", (Resolve-Path $ruleTestResultsFile))
-        if ($ruleTestResults.FailedCount -gt 0) {
-            throw "$($ruleTestResults.FailedCount) tests failed."
-        }
 
 # Upload the project along with TestResults as a zip archive
 on_finish:

build.ps1

@@ -132,7 +132,7 @@ if ($Install)
 
 if ($Test)
 {
-    Import-Module -Name Pester -MinimumVersion 3.4.0 -ErrorAction Stop
+    Import-Module -Name Pester -MinimumVersion 4.1.1 -ErrorAction Stop
     Function GetTestRunnerScriptContent($testPath)
     {
         $x = @"
@@ -202,4 +202,4 @@ if ($Test)
 if ($Uninstall)
 {
     Remove-Item -Path $modulePSSAPath -Force -Verbose:$verbosity -Recurse
-}
+}

buildCoreClr.ps1

@@ -31,6 +31,7 @@ function Invoke-RestoreSolution
     dotnet restore (Join-Path $PSScriptRoot .\PSScriptAnalyzer.sln)
 }
 
+Write-Progress "Building ScriptAnalyzer"
 $solutionDir = Split-Path $MyInvocation.InvocationName
 if (-not (Test-Path "$solutionDir/global.json"))
 {
@@ -63,6 +64,7 @@ if ($Restore.IsPresent)
 if ($build)
 {
 
+    Write-Progress "Building Engine"
     if (-not (Test-DotNetRestore((Join-Path $solutionDir Engine))))
     {
         Invoke-RestoreSolution
@@ -76,6 +78,7 @@ if ($build)
     {
         Invoke-RestoreSolution
     }
+    Write-Progress "Building for framework $Framework, configuration $Configuration"
     Push-Location Rules\
     dotnet build Rules.csproj --framework $Framework --configuration $Configuration
     Pop-Location
@@ -84,23 +87,26 @@ if ($build)
     {
         if (-not (Test-Path $destination))
         {
-            New-Item -ItemType Directory $destination -Force
+            $null = New-Item -ItemType Directory $destination -Force
         }
         foreach ($file in $itemsToCopy)
         {
-            Copy-Item -Path $file -Destination (Join-Path $destination (Split-Path $file -Leaf)) -Verbose -Force
+            Copy-Item -Path $file -Destination (Join-Path $destination (Split-Path $file -Leaf)) -Force
         }
     }
+
+
+    Write-Progress "Copying files to $destinationDir"
     CopyToDestinationDir $itemsToCopyCommon $destinationDir
     CopyToDestinationDir $itemsToCopyBinaries $destinationDirBinaries
 
     # Copy Settings File
-    Copy-Item -Path "$solutionDir\Engine\Settings" -Destination $destinationDir -Force -Recurse -Verbose
+    Copy-Item -Path "$solutionDir\Engine\Settings" -Destination $destinationDir -Force -Recurse
 
     # copy newtonsoft dll if net451 framework
     if ($Framework -eq "net451")
     {
-        copy-item -path "$solutionDir\Rules\bin\$Configuration\$Framework\Newtonsoft.Json.dll" -Destination $destinationDirBinaries -Verbose
+        copy-item -path "$solutionDir\Rules\bin\$Configuration\$Framework\Newtonsoft.Json.dll" -Destination $destinationDirBinaries
     }
 }
 
@@ -112,11 +118,12 @@ if ($uninstall)
 {
     if ((Test-Path $pssaModulePath))
     {
-        Remove-Item -Recurse $pssaModulePath -Verbose
+        Remove-Item -Recurse $pssaModulePath
     }
 }
 
 if ($install)
 {
-    Copy-Item -Recurse -Path "$destinationDir" -Destination "$modulePath\." -Verbose -Force
-}
+    Write-Progress "Installing to $modulePath"
+    Copy-Item -Recurse -Path "$destinationDir" -Destination "$modulePath\." -Force
+}