Skip to content

PSReadline crashed on daily build #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TravisEz13 opened this issue May 26, 2021 · 5 comments · Fixed by #2524
Closed

PSReadline crashed on daily build #2495

TravisEz13 opened this issue May 26, 2021 · 5 comments · Fixed by #2524
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Fixed

Comments

@TravisEz13
Copy link
Member

Environment

PSReadLine: 2.2.0-beta1
PowerShell: 7.2.0-daily20210525.1
OS: Darwin 20.4.0 Darwin Kernel Version 20.4.0: Thu Apr 22 21:46:47 PDT 2021; root:xnu-7195.101.2~1/RELEASE_X86_64
BufferWidth: 125
BufferHeight: 41

Last 0 Keys


Exception

System.TypeLoadException: Could not load type 'System.Management.Automation.Subsystem.PredictionResult' from assembly 'Microsoft.PowerShell.PSReadLine.Polyfiller, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.
   at Microsoft.PowerShell.PSConsoleReadLine.PredictionViewBase.Reset()
   at Microsoft.PowerShell.PSConsoleReadLine.PredictionInlineView.Reset()
   at Microsoft.PowerShell.PSConsoleReadLine.Prediction.Reset()
   at Microsoft.PowerShell.PSConsoleReadLine.Initialize(Runspace runspace, EngineIntrinsics engineIntrinsics)
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken)

Steps to reproduce

start pwsh from the 7.2.0-daily20210525.1 build on macOS

Expected behavior

pwsh should start

Actual behavior

### Environment
PSReadLine: 2.2.0-beta1
PowerShell: 7.2.0-daily20210525.1
OS: Darwin 20.4.0 Darwin Kernel Version 20.4.0: Thu Apr 22 21:46:47 PDT 2021; root:xnu-7195.101.2~1/RELEASE_X86_64
BufferWidth: 125
BufferHeight: 41

Last 0 Keys

### Exception

System.TypeLoadException: Could not load type 'System.Management.Automation.Subsystem.PredictionResult' from assembly 'Microsoft.PowerShell.PSReadLine.Polyfiller, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.
at Microsoft.PowerShell.PSConsoleReadLine.PredictionViewBase.Reset()
at Microsoft.PowerShell.PSConsoleReadLine.PredictionInlineView.Reset()
at Microsoft.PowerShell.PSConsoleReadLine.Prediction.Reset()
at Microsoft.PowerShell.PSConsoleReadLine.Initialize(Runspace runspace, EngineIntrinsics engineIntrinsics)
at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken)

work around

launch with pwsh-daily -noprofile -noninteractive

@ghost ghost added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label May 26, 2021
@TravisEz13
Copy link
Member Author

repros with beta 2 of psreadline as well

@daxian-dbw
Copy link
Member

A breaking change to the command prediction experimental feature was merged on 5/20, and now changes to PSReadLine need to be done to work with the new interface. For now, I'm afraid you will have to switch to PSReadLine 2.1.0 temporarily, or you can use -noninteractive when working with the latest bits for the time being. The PSReadLine side changes are done, but the release of it will have to wait until after the next preview release of PowerShell because it depends on the NuGet packages.

@daxian-dbw daxian-dbw added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. labels May 26, 2021
@iSazonov
Copy link

Dup #2482

@ghost ghost added the Resolution-Fixed label Jun 1, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

🎉 This issue was addressed in 2524, which has now been successfully released in v2.2.0-beta3. 🎉

@HerbM
Copy link

HerbM commented Jun 22, 2021

7.2.0-preview.7 and PSReadLine 2.2.0 beta3 seem to be working on first examination.

(7.2.0-preview.5 and PSReadLine 2.2.0 beta3 did not work together.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Fixed
Projects
None yet
4 participants