Skip to content

remove duplicate matches for comparison #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2018

Conversation

omniomi
Copy link
Contributor

@omniomi omniomi commented May 21, 2018

Resolves #54. Comparison operators were covered twice:

<dict>	
	<key>match</key>	
	<string>(?&lt;!\w)-([ci]?[lg][te]|eq|ne)</string>	
	<key>name</key>	
	<string>keyword.operator.logical.powershell</string>	
</dict>

and

<dict>
	<key>match</key>
	<string>(?&lt;!\w)-(?i:[ic]?(?:eq|ne|[gl][te]|(?:not)?(?:like|match|contains|in)|replace))(?!\p{L})</string>
	<key>name</key>
	<string>keyword.operator.comparison.powershell</string>
</dict>

Removed the less complete of the duplicates:

length

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@omniomi
Copy link
Contributor Author

omniomi commented May 25, 2018

@tylerl0706 can you merge this in please?

@TylerLeonhardt TylerLeonhardt merged commit 8ec9066 into PowerShell:master May 25, 2018
@omniomi omniomi deleted the fix-operators branch May 25, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants