Bundled Time::Local fails tests in 5.28 and below

[tom-binary]

Module: Time::Local

Description

Older perl versions - e.g. 5.26.2 - no longer pass tests due to the 50-year bug in Time::Local, which was fixed in 1.26:

https://metacpan.org/changes/distribution/Time-Local#L22

cpan/Time-Local/t/Local ........................................ #   Failed test 'timelocal year for 1970 1 2 0 0 0'
#   at t/Local.t line 109.
#          got: '170'
#     expected: '70'
#   Failed test 'timegm year for 1970 1 2 0 0 0'
#   at t/Local.t line 124.
#          got: '170'
#     expected: '70'
# Looks like you failed 2 tests of 187.
FAILED at test 6

Steps to Reproduce

Install any version of Perl with bundled Time::Local < 1.26. According to corelist -a, it affects everything before the 5.30 series:

  v5.28.2    1.25      
  v5.29.0    1.25      
  v5.29.1    1.28

Expected behavior

Passing tests.

Perl configuration

Works better when the Perl build completes 😄

[karenetheridge]

Perls before 5.28 are out of the support window, so the only way to solve this is with a patch applied via Devel::PatchPerl (which some systems such as perlbrew use).

[karenetheridge]

It's possible (although unlikely) that there might be a 5.28.3 release before it falls outside the support window (May 2020), so Time::Local could be updated in maint-5.28. 5.30.0 already contains a new enough version.

[zakame]

ISTR Devel::PatchPerl will add patches for configures, not tests: https://metacpan.org/pod/Devel::PatchPerl#CAVEAT

FWIW this affects docker-perl images as well, though at least we have another mechanism there for adding patches sourced from elsewhere other than D::PP.