-
-
Notifications
You must be signed in to change notification settings - Fork 283
Adding accessibility identifiers to PFLogInView and PFSignUpView #214
Conversation
|
Whee! This is great! Didn't know someone actually cares about ui testing our components. 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Per our style - could you remove the space between * and const, as the star should only be space separated on the left.
|
Ok, that's about it as far as I can see right now. |
|
@nlutsenko done! thx for the thorough review |
|
@huguesbr updated the pull request. |
|
@nlutsenko anything else, it should be PR ready..! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Add line break before line 41 per overall code style.
|
Few missing/extra line breaks and will merge it in. |
|
@huguesbr updated the pull request. |
|
@nlutsenko all done.. wish there was a good linter for objc-c... thx |
|
We are using a |
|
Last piece - could you squash all commits into a single one? I will merge it straight after. |
82f9ff3 to
e387bae
Compare
|
@nlutsenko done |
|
Whee! |
Adding accessibility identifiers to PFLogInView and PFSignUpView
|
@nlutsenko thx for playing linter... |
Adding accessibility identifiers for easier UI Automation Testing.