Skip to content

Fix division by zero #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2017
Merged

Fix division by zero #887

merged 2 commits into from
Nov 7, 2017

Conversation

taophp
Copy link

@taophp taophp commented Sep 12, 2016

See #886

msphn
msphn suggested changes Dec 13, 2016
View reviewed changes
Copy link

@msphn msphn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change could you please have a look at the coding guidelines? Please apply PSR-1/PSR-2 and add wrap comparison with spaces! 👍

@taophp
Copy link
Author

taophp commented Dec 13, 2016

I add the spaces you ask for. I read the PSR-1 and 2. I do not figure how I did not follow them, if I did. Please, let me know if you need more changes.
BTW, I did not know where to find your coding guidelines.

@troosan troosan merged commit 75bf84f into PHPOffice:develop Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msphn msphn msphn requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taophp @msphn @troosan