-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Generate Table Cell if Row Doesn't Have Any #2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
147 changes: 147 additions & 0 deletions
147
tests/PhpWordTests/Writer/Word2007/Element/TableTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| <?php | ||
| /** | ||
| * This file is part of PHPWord - A pure PHP library for reading and writing | ||
| * word processing documents. | ||
| * | ||
| * PHPWord is free software distributed under the terms of the GNU Lesser | ||
| * General Public License version 3 as published by the Free Software Foundation. | ||
| * | ||
| * For the full copyright and license information, please read the LICENSE | ||
| * file that was distributed with this source code. For the full list of | ||
| * contributors, visit https://github.com/PHPOffice/PHPWord/contributors. | ||
| * | ||
| * @see https://github.com/PHPOffice/PHPWord | ||
| * | ||
| * @license http://www.gnu.org/licenses/lgpl.txt LGPL version 3 | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace PhpOffice\PhpWordTests\Writer\Word2007\Element; | ||
|
|
||
| use PhpOffice\PhpWord\PhpWord; | ||
| use PhpOffice\PhpWord\SimpleType\TblWidth; | ||
| use PhpOffice\PhpWordTests\TestHelperDOCX; | ||
|
|
||
| /** | ||
| * Test class for PhpOffice\PhpWord\Writer\Word2007\Element subnamespace. | ||
| */ | ||
| class TableTest extends \PHPUnit\Framework\TestCase | ||
| { | ||
| /** | ||
| * Executed after each method of the class. | ||
| */ | ||
| protected function tearDown(): void | ||
| { | ||
| TestHelperDOCX::clear(); | ||
| } | ||
|
|
||
| public static function testTableNormal(): void | ||
| { | ||
| $phpWord = new PhpWord(); | ||
| $section = $phpWord->addSection(); | ||
| $section->addText('Before table (normal).'); | ||
| $table = $section->addTable(['width' => 5000, 'unit' => TblWidth::PERCENT]); | ||
| $row = $table->addRow(); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R1C1'); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R1C2'); | ||
| $row = $table->addRow(); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R2C1'); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R2C2'); | ||
| $row = $table->addRow(); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R3C1'); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R3C2'); | ||
| $section->addText('After table.'); | ||
|
|
||
| $doc = TestHelperDOCX::getDocument($phpWord); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl[2]'), 'should be only 1 table'); | ||
|
|
||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc[2]')); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc[3]')); | ||
|
|
||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]/w:tc')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]/w:tc[2]')); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]/w:tc[3]')); | ||
|
|
||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]/w:tc')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]/w:tc[2]')); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]/w:tc[3]')); | ||
| } | ||
|
|
||
| public static function testSomeRowWithNoCells(): void | ||
| { | ||
| $phpWord = new PhpWord(); | ||
| $section = $phpWord->addSection(); | ||
| $section->addText('Before table (row 2 has no cells).'); | ||
| $table = $section->addTable(['width' => 5000, 'unit' => TblWidth::PERCENT]); | ||
| $row = $table->addRow(); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R1C1'); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R1C2'); | ||
| $row = $table->addRow(); | ||
| $row = $table->addRow(); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R3C1'); | ||
| $tc = $table->addCell(); | ||
| $tc->addText('R3C2'); | ||
| $section->addText('After table.'); | ||
|
|
||
| $doc = TestHelperDOCX::getDocument($phpWord); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl[2]'), 'should be only 1 table'); | ||
|
|
||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc[2]')); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc[3]')); | ||
|
|
||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]/w:tc')); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]/w:tc[2]')); | ||
|
|
||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]/w:tc')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]/w:tc[2]')); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[3]/w:tc[3]')); | ||
| } | ||
|
|
||
| public static function testOnly1RowWithNoCells(): void | ||
| { | ||
| $phpWord = new PhpWord(); | ||
| $section = $phpWord->addSection(); | ||
| $section->addText('Before table (only 1 row and it has no cells).'); | ||
| $table = $section->addTable(['width' => 5000, 'unit' => TblWidth::PERCENT]); | ||
| $row = $table->addRow(); | ||
| $section->addText('After table.'); | ||
|
|
||
| $doc = TestHelperDOCX::getDocument($phpWord); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl[2]'), 'only 1 table should be written'); | ||
|
|
||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]')); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc')); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[1]/w:tc[2]')); | ||
|
|
||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl/w:tr[2]')); | ||
| } | ||
|
|
||
| public static function testNoRows(): void | ||
| { | ||
| $phpWord = new PhpWord(); | ||
| $section = $phpWord->addSection(); | ||
| $section->addText('Before table (no rows therefore omitted).'); | ||
| $table = $section->addTable(['width' => 5000, 'unit' => TblWidth::PERCENT]); | ||
| $section->addText('After table.'); | ||
|
|
||
| $doc = TestHelperDOCX::getDocument($phpWord); | ||
| self::assertFalse($doc->elementExists('/w:document/w:body/w:tbl[1]'), 'no table should be written'); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.