Skip to content

Add DomPDF to composer.json and enable archived image source #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2014

Conversation

ivanlanin
Copy link
Contributor

Guys, please review the following changes:

  • Add DomPDF to require-dev in composer.json to enable unit testing for PDF writer
  • Enable zip://$archiveFile#$imageFile construct for image source to enable reading from DOCX

Thanks

@Progi1984
Copy link
Member

@ivanlanin We will have a very good PDF writer.

Some notes :

  • When the docs will be generated, warning to the table for the correct display
  • Personnaly, I would add dompdf in "suggest" of composer.json with an explanation

@ivanlanin
Copy link
Contributor Author

Thanks @Progi1984.

  1. Did you mean (a) there's a warning message E_WARNING or (b) there should be a warning to users that tables are not (yet) rendered correctly with the current writers?
  2. I agree, but how can we make Travis install dompdf?

@Progi1984
Copy link
Member

@ivanlanin :

  1. I mean : We should care that the rendering of the table be well.
  2. For suggested packages, I think we should add travis commands in .travis.yml for install anothers packages. (Ref : https://getcomposer.org/doc/03-cli.md#require)

@ivanlanin
Copy link
Contributor Author

  1. Ok. We'll test table rendering with special care.
  2. composer.json and .travis.yml updated. Travis build passed.

@Progi1984 Progi1984 added this to the 0.10.0 milestone Apr 16, 2014
@Progi1984
Copy link
Member

Perfect for me :)

@ivanlanin ivanlanin mentioned this pull request Apr 16, 2014
ivanlanin added a commit that referenced this pull request Apr 16, 2014
Add DomPDF to composer.json and enable archive image source
@ivanlanin ivanlanin merged commit 898be23 into PHPOffice:develop Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants