Skip to content

move index for Cloned Blocks with values #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Amerlander
Copy link

@Amerlander Amerlander commented Feb 25, 2020

Description

If an image field like ${IMAGE:10cmx15cm} gets cloned it returns now ${IMAGE#1:10cmx15cm} instead of ${IMAGE:10cmx15cm#1} and therefore wouldn't break the image field anymore.

Fixes #1624

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

If an image field like `${IMAGE:10cmx15cm}` gets cloned it returns now `${IMAGE#1:10cmx15cm}` instead of `${IMAGE:10cmx15cm#1} and therefore wouldn't break the image field anymore.

Closes PHPOffice#1624
@Amerlander
Copy link
Author

sorry, duplicate of #1763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update for setImageValue() inside clonedBlock with indexed values
1 participant