Fix: CloneBlock regexp for different regexp engine with xml line-drop

[juzser]

Description

Reference Issue: #1800
When you have multiple Blocks in multiple Rows, some of blocks cannot be replaced
Only the last block was replaced.
This because some word file will drop-line after xml tag, and the regular expression engine in different versions cannot find the matched block.

Fixes # (issue)
File: TemplateProcessor.php
Line: 740

Change the regexp pattern to:

'/(.*((?s)<w:p\b(?:(?!<w:p\b).)*?\${' . $blockname . '}<\/w:.*?p>))(.*)((?s)<w:p\b(?:(?!<w:p\b).)*?\${\/' . $blockname . '}<\/w:.*?p>)/is',

Describe:

• Do not find for xml.
• Start find the <w:p tag that closest to the blockname.
• This <w:p does not contain any other <w:p inside it.

Checklist:

All Done

• I have run composer run-script check --timeout=0 and no errors were reported
• The new code is covered by unit tests (check build/coverage for coverage report)
• I have updated the documentation to describe the changes

[coveralls]

Coverage remained the same at 94.633% when pulling 5f28595 on JuzSer:cloneblock-regexp into 733f845 on PHPOffice:develop.

[juzser]

Update PR: #1809

[Herz3h]

I encountered an I issue where my blocks were not cloned (basically preg_match didn't match anything). I changed regex to what's used here, and it was fixed. Can we merge this ?

[juzser]

I encountered an I issue where my blocks were not cloned (basically preg_match didn't match anything). I changed regex to what's used here, and it was fixed. Can we merge this ?

@Herz3h Feel free to use it. Or you can use my fork repo here: https://github.com/JuzSer/PHPWord

[Herz3h]

Would prefer to have it merged, so I don't forget later on that I'm using your repo instead of the official one in my composer ;)

[xu-li]

In my case, it works if pcre.jit is enabled on php 7.3.6. And it will also work if pcre.backtrack-limit is big enough when pcre.jit. is disabled.

Those might not be good solutions, but could be served as temporary solution before the official fix.

[juzser]

In my case, it works if pcre.jit is enabled on php 7.3.6. And it will also work if pcre.backtrack-limit is big enough when pcre.jit. is disabled.

Those might not be good solutions, but could be served as temporary solution before the official fix.

@xu-li Yes, I see that problem before, long time ago I posted an update PR here: #1809
This will solve the catastrophic backtracking. You can try this.

[xu-li]

Thanks, @juzser . Yes, I saw your PR, tried that and it worked in my particular case.

I didn't use your code because:

• We use phpword in production.
• Regular expression is a beast to me and I am not familiar with the details of cloneBlock. I couldn't evaluate if your regular expression will work for all the use cases.

It's just my personal preference. I want to play on the safe side. It has nothing to do with your code.

[juzser]

Yes, of course. I've tested my regexp with some cases, I think it safe but yes, you're correct, maybe I missed something that I don't know.

I'm just waiting for the package's owner to check this issue.. But seem likes he has no longer maintenance this package, maybe.

[troosan]

merged #1809