Skip to content

move from "zendframework/zend-escaper" to "laminas/laminas-escaper" #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

DeyV
Copy link

@DeyV DeyV commented Jan 3, 2020

move from "zendframework/zend-escaper" to "laminas/laminas-escaper" due to Zend Framework migration

Description

Zend Framework repos are archived and unmaintaned. New name for this project is laminas

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)

@michaljusiega
Copy link

Let's finish this PR please, I am annoyed by migration messages.

@DeyV
Copy link
Author

DeyV commented Feb 3, 2020

Let's finish this PR please, I am annoyed by migration messages.

this is harder to do than I thought because laminas declare no support for not supported php versions. ( laminas/laminas-zendframework-bridge#44 , laminas/laminas-zendframework-bridge#43 ) and at this moment I don't know - if its actual declaration, or not.

Maybe is't time to change list of supported php versions in PHPWord - but I can't decide for the PHPWord team

@coveralls
Copy link

coveralls commented Feb 3, 2020

Coverage Status

Coverage remained the same at 94.633% when pulling 0746ac5 on DeyV:develop into 733f845 on PHPOffice:develop.

@DeyV
Copy link
Author

DeyV commented Feb 3, 2020

Fixed dependencies for php74

@repat
Copy link

repat commented Feb 23, 2020

Any holdups on this? How can we help? :)

@DeyV
Copy link
Author

DeyV commented Feb 23, 2020

You have two options

@dv336699
Copy link
Contributor

@troosan this PR can be closed in favour of #1916

@troosan
Copy link
Contributor

troosan commented Feb 7, 2021

#1946 already merged for this

@troosan troosan closed this Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants