Skip to content

Code refactoring #160

Closed
Closed
@ivanlanin

Description

@ivanlanin

Since namespace is closing by, here are some issues that I'd like to propose:

  • Change "Section" folder to "Element" since all classes that we put there are not only for "section".
  • Create a "Collection" or "Container" folder for Section, Header, Footer, and other classes that can contain elements. I admit that Cell, Footnote, and TextRun are confusing.
  • Rename "Exceptions" into "Exception". All other folders are in singular forms.
  • Lower case "Tests" into "tests" so we have all root folders in lower cases.
  • Create a parent class for "Container" and "Element". PHP CPD reports too many similiar piece of code.
  • Merge Table and TableFull style. They're the same.
  • Merge Image and MemoryImage element. We can manage to see the difference internally.

Thanks.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions