Add parameter validation for pageNumber and pageSize

Author: osm-Jatin

src/Core/Services/RoleService.cs

@@ -42,6 +42,10 @@ public async Task<int> GetTotalRolesCountAsync()
 
     public async Task<IEnumerable<RoleResponseDto>> GetAllRolesAsync(int pageNumber, int pageSize)
     {
+        if (pageNumber <= 0 || pageSize <= 0)
+        {
+            throw new BadRequestException("pageNumber and pageSize must be greater than zero.");
+        }
         IEnumerable<Role> roles = await _roleRepository.GetAllRolesAsync(pageNumber, pageSize).ConfigureAwait(false);
         if (!roles.Any())
         {

src/Core/Services/UserService.cs

@@ -24,6 +24,11 @@ public UserService(ITokenService tokenService, IRoleRepository roleRepository, I
 
     public async Task<string?> Login(string email, string password)
     {
+        if (string.IsNullOrWhiteSpace(email) || string.IsNullOrWhiteSpace(password))
+        {
+            throw new BadRequestException("Email and password are required.");
+        }
+
         User? user = await _userRepository.GetUserByEmailAsync(email).ConfigureAwait(false);
         if (user == null || !VerifyPassword(password, user.PasswordHash))
         {
@@ -66,6 +71,10 @@ public async Task<int> GetTotalUsersCountAsync()
 
     public async Task<IEnumerable<UserResponseDto>> GetAllUsersAsync(int pageNumber, int pageSize)
     {
+        if (pageNumber <= 0 || pageSize <= 0)
+        {
+            throw new BadRequestException("pageNumber and pageSize must be greater than zero.");
+        }
         IEnumerable<User> users = await _userRepository.GetAllUsersAsync(pageNumber, pageSize).ConfigureAwait(false);
         if (!users.Any())
         {
@@ -114,6 +123,12 @@ public async Task<IEnumerable<UserResponseDto>> GetAllUsersAsync(int pageNumber,
             throw new AlreadyExistsException($"User with email {userDto.Email} already exists.");
         }
 
+        Role? role = await _roleRepository.GetRoleByIdAsync(userDto.RoleId).ConfigureAwait(false);
+        if (role == null)
+        {
+            throw new NotFoundException($"Role with ID {userDto.RoleId} not found.");
+        }
+
         _mapper.Map(userDto, user);
         user.SetRole(userDto.RoleId);
         User? updatedUser = await _userRepository.UpdateUserAsync(user).ConfigureAwait(false);