This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Fix npm test script #112
Closed
Fix npm test script #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tyleryasaka is this one still good to go? Looks pretty minor and could be included in 0.5.9 release. |
Before this was failing on jest errors. This fixes the script so that it doesn't fail. (There are still no tests.) We were getting this error: facebook/create-react-app#1319
tyleryasaka
force-pushed
the
fix-test-script
branch
from
dcddc78 to
cb14861
Compare
|
@wanderingstan Just resolved the conflicts - this is good to go. Kinda wondering if we should just remove the test script altogether since it's not being used, unless we plan to actually use it soon. Either way, we can go ahead and merge this and think about that later. |
|
I see this issue has been addressed now. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
developbranch instead ofmasterDescription:
Before this was failing on jest errors. This fixes the script so that it doesn't fail. (There are still no tests.)
We were getting this error: facebook/create-react-app#1319