Update struct definitions #134
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmosc
commented
Jul 12, 2025
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| #include "OGBase.h" | |||
|
|
|||
| typedef OG_OPTIONS(uint32_t, OGAttributeFlags) { | |||
| typedef OG_OPTIONS(uint8_t, OGAttributeFlags) { | |||
There was a problem hiding this comment.
This gets stored as an 8-bit field in AG::Node.
jcmosc
commented
Jul 12, 2025
Comment on lines
+36
to
+39
| struct { | ||
| OGTypeID type_id; | ||
| const void *witness_table; | ||
| } body_conformance; |
There was a problem hiding this comment.
@Kyle-Ye This doesn't appear in the swift section dump you provided, but I can see it being set in Ghidra's disassembly. I'm not sure if there is a difference in behaviour depending on version.
There was a problem hiding this comment.
Do we miss something in swift section? Maybe we can try to use Ghidra and align those logic. cc @Mx-Iris
jcmosc
commented
Jul 12, 2025
jcmosc
commented
Jul 12, 2025
Kyle-Ye
reviewed
Jul 12, 2025
Kyle-Ye
reviewed
Jul 12, 2025
Kyle-Ye
reviewed
Jul 12, 2025
Kyle-Ye
reviewed
Jul 12, 2025
Kyle-Ye
reviewed
Jul 12, 2025
Kyle-Ye
reviewed
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.