Skip to content

feat(auth): add password visibility toggle #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bahati308 merged 1 commit into from
Dec 11, 2025
Merged

feat(auth): add password visibility toggle #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 150 additions & 0 deletions formulus/src/components/common/PasswordInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,150 @@
import React, {useState} from 'react';
import {
TextInput,
Text,
View,
StyleSheet,
TextInputProps,
ViewStyle,
TouchableOpacity,
} from 'react-native';
import Icon from 'react-native-vector-icons/MaterialCommunityIcons';

export interface PasswordInputProps extends Omit<TextInputProps, 'secureTextEntry'> {
label?: string;
error?: string;
containerStyle?: ViewStyle;
testID?: string;
/**
* Show label above the input (default: true)
*/
showLabel?: boolean;
}

/**
* Reusable PasswordInput component with visibility toggle.
*/
const PasswordInput: React.FC<PasswordInputProps> = ({
label,
error,
containerStyle,
testID,
style,
showLabel = true,
...textInputProps
}) => {
const [isPasswordVisible, setIsPasswordVisible] = useState(false);

const togglePasswordVisibility = () => {
setIsPasswordVisible(prev => !prev);
};

const accessibilityLabel = isPasswordVisible
? 'Hide password'
: 'Show password';

// Extract paddingHorizontal from style to calculate proper paddingRight
const inputStyle = StyleSheet.flatten([styles.input, style]);
const paddingHorizontal = inputStyle.paddingHorizontal || 12;
const paddingRight = typeof paddingHorizontal === 'number'
? paddingHorizontal + 40 // Space for icon + some padding
: 45; // Default fallback

return (
<View style={[styles.container, containerStyle]}>
{showLabel && label && <Text style={styles.label}>{label}</Text>}
<View style={styles.inputContainer}>
<TextInput
{...textInputProps}
style={[
styles.input,
error && styles.inputError,
textInputProps.multiline && styles.inputMultiline,
style,
{paddingRight}, // Ensure icon space is always available
]}
secureTextEntry={!isPasswordVisible}
placeholderTextColor={textInputProps.placeholderTextColor || '#999999'}
testID={testID}
accessibilityLabel={
textInputProps.accessibilityLabel ||
label ||
textInputProps.placeholder ||
'Password input'
}
accessibilityRole="text"
accessibilityState={{invalid: !!error}}
/>
<TouchableOpacity
style={styles.eyeButton}
onPress={togglePasswordVisibility}
accessibilityLabel={accessibilityLabel}
accessibilityRole="button"
accessibilityHint={
isPasswordVisible
? 'Tap to hide password'
: 'Tap to show password'
}
hitSlop={{top: 10, bottom: 10, left: 10, right: 10}}>
<Icon
name={isPasswordVisible ? 'eye-off' : 'eye'}
size={22}
color="#666666"
/>
</TouchableOpacity>
</View>
{error && <Text style={styles.errorText}>{error}</Text>}
</View>
);
};

const styles = StyleSheet.create({
container: {
marginBottom: 16,
},
label: {
fontSize: 14,
fontWeight: '500',
color: '#333333',
marginBottom: 8,
},
inputContainer: {
position: 'relative',
flexDirection: 'row',
alignItems: 'center',
},
input: {
flex: 1,
height: 48,
borderWidth: 1,
borderColor: '#CCCCCC',
borderRadius: 8,
paddingHorizontal: 12,
fontSize: 16,
color: '#000000',
backgroundColor: '#FFFFFF',
},
inputError: {
borderColor: '#FF3B30',
},
inputMultiline: {
minHeight: 48,
paddingTop: 12,
paddingBottom: 12,
},
eyeButton: {
position: 'absolute',
right: 12,
padding: 4,
justifyContent: 'center',
alignItems: 'center',
},
errorText: {
fontSize: 12,
color: '#FF3B30',
marginTop: 4,
},
});

export default PasswordInput;

2 changes: 2 additions & 0 deletions formulus/src/components/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
export { default as Button } from './Button';
export { default as Input } from './Input';
export { default as PasswordInput } from './PasswordInput';
export type { PasswordInputProps } from './PasswordInput';
8 changes: 4 additions & 4 deletions formulus/src/screens/SettingsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {serverConfigService} from '../services/ServerConfigService';
import QRScannerModal from '../components/QRScannerModal';
import {QRSettingsService} from '../services/QRSettingsService';
import {MainAppStackParamList} from '../types/NavigationTypes';
import {PasswordInput} from '../components/common';

type SettingsScreenNavigationProp = StackNavigationProp<
MainAppStackParamList,
Expand Down Expand Up @@ -268,16 +269,15 @@ const SettingsScreen = () => {
</View>

<View style={styles.section}>
<Text style={styles.label}>Password</Text>
<TextInput
style={styles.input}
<PasswordInput
label="Password"
placeholder="••••••••"
placeholderTextColor="#999"
value={password}
onChangeText={setPassword}
secureTextEntry
autoCapitalize="none"
autoCorrect={false}
style={styles.input}
/>
</View>

Expand Down
Loading