-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Updates to parameter and requestBody #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reusing the name from https://tools.ietf.org/html/rfc6570#section-3.2.2, like the other |
OK sure, but it still sucks |
Alternatives welcome. |
|
We can discuss it tomorrow. I don't think it's a good idea because unlike in 2.0, it cannot be applied to
|
Were there still open issues here? I thought we resolved everything. |
Per our discussion, changed the default value of |
Updates to parameter and requestBody
Summary of changes:
commaDelimited
tosimple
, reference the type in the RFC and made not applicable toquery
. Described behavior for primitive value, added exploded example.style
based on parameter type.allowEmptyValue
is inapplicable if example table value isn/a
.style
ofx-www-form-urlencoded
toform
, set behavior to be likequery
parameters.contentType
not required, described default values.Note that the behavior of
headeer
andcookie
parameters is different than what we discussed.header
For values
[ red, green, blue ]
:will be
colors: red,green,blue
regardless of whetherexplode
is true/false.This is different than the discussed result of
explode
true represented as:colors: colors=red&colors=green&colors=blue
.cookie
By following
style
beingform
, we get the representation ofSet-Cookie: colors=red,green,blue
by default, so no extra explanation needed (unlike usingsimple
).Open issues:
explode
beingtrue
forcookie
parameter will look like?collectionFormat
by default bemulti
and notcsv
. This means that we should setexplode
totrue
forquery
parameters by default. It's a cumbersome explanation (if this then that, otherwise something else), but doable. Opinions welcome.