Skip to content

Very minor formatting suggestion #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v3.1-dev
Choose a base branch
from
Open

Very minor formatting suggestion #4601

wants to merge 1 commit into from

Conversation

lornajane
Copy link
Contributor

I noticed strange formatting on two lines in the 3.1 specification file (one is fixed in 3.2, one is not).

@lornajane lornajane requested review from a team as code owners May 16, 2025 19:19
@handrews
Copy link
Member

@lornajane I'm guessing you meant to open this against v3.1-dev and not main?

@lornajane lornajane changed the base branch from main to v3.1-dev May 18, 2025 13:28
@lornajane
Copy link
Contributor Author

oops! Thanks @handrews , you are correct of course

handrews
handrews approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks! I thought I got these on 3.2 with the last encoding fix but apparently I did not get them both- I have added the remaining 3.2 fix to PR #4589 as it is close to this part of the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

@miqui miqui miqui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lornajane @handrews @miqui