-
Notifications
You must be signed in to change notification settings - Fork 9.1k
feat: adds additional operations for path item object #4514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a failing test case trying to use "GET" as an additional operation?
Co-authored-by: Ralf Handl <[email protected]>
Co-authored-by: Ralf Handl <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
…ent object Signed-off-by: Vincent Biret <[email protected]>
done. I added POST instead to make it clear that it's not just a collision with what's defined in the document, but rather a matter of "where things should go". |
Co-authored-by: Ralf Handl <[email protected]>
@baywet @kevinswiber I did not see a reply in the issue to my idea that we include |
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
I don't have a strong preference either way. If it's about to be a "well known" method/verb, I think it makes sense to hoist it. Added it (push soon). |
Signed-off-by: Vincent Biret <[email protected]>
Co-authored-by: Henry Andrews <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Co-authored-by: Henry Andrews <[email protected]>
Co-authored-by: Henry Andrews <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixing my copy-paste error!
Co-authored-by: Ethan <[email protected]>
@ralfhandl for a final review/approval/merge with the latest minor edits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, just one typo and one omission
Co-authored-by: Ralf Handl <[email protected]>
Co-authored-by: Ralf Handl <[email protected]>
fixes #1747