Skip to content

main: status check for changes to versions and schemas folder #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Mar 2, 2025

This PR adds a workflow that checks for changes to files in the schemas and versions folder.

This workflow SHOULD NOT become a required check because

  • we still need to add future spec versions to the versions folder
  • we want to propagate new spec versions from main to dev and vX.Y-dev etc.

So this will be a "red flag" that can be disregarded, which is better than no warning, and may help to prevent accidents such as #4328 targeting the wrong file.

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

Simple workflow to check for changes to files in schemas and versions folder
@ralfhandl ralfhandl force-pushed the main-protect-files branch from 022fe53 to fa1f64a Compare March 3, 2025 13:15
@ralfhandl ralfhandl marked this pull request as ready for review March 3, 2025 13:24
@ralfhandl ralfhandl requested review from a team as code owners March 3, 2025 13:24
@ralfhandl ralfhandl changed the title experiment, disregard for now main: status check for changes to versions and schemas folder Mar 3, 2025
@lornajane
Copy link
Contributor

Mostly because I'm curious: why do it this way rather than with a path filter that would fire when we changed anything in the matching paths?

Co-authored-by: Lorna Jane Mitchell <[email protected]>
@ralfhandl
Copy link
Contributor Author

Thanks, let's try that 😄

@ralfhandl
Copy link
Contributor Author

@ralfhandl ralfhandl closed this Mar 4, 2025
@ralfhandl ralfhandl deleted the main-protect-files branch March 4, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants