Skip to content

gh-pages: skip dialect base & meta base #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ralfhandl
Copy link
Contributor

Follow-up to

  • Only list date-stamped schema iterations for dialect and meta

Preview:

@handrews
Copy link
Member

Why do we need to treat these differently? We want all of the schema files to be treated the same. If we need to group them to show the dependencies, then we should figure out how to do that (probably by generating some YAML file to iterate over rather than trying to do anything complex in Jekyll/Liquid). But for now, just showing all revisions for all four is correct (and ideally also showing the old */base ones since we should schema/$date and schema-base/$date that depend on them.

@ralfhandl
Copy link
Contributor Author

We want all of the schema files to be treated the same.

That would mean that base is before the newer date-stamped iterations because "the same" means "in descending lexicographical order". Moving base after the newer date-stamped iterations exceeds my Liquid skills - I've tried and failed.

@handrews
Copy link
Member

@ralfhandl Oh I see, I had misunderstood this a bit. Let me think on it...

@handrews handrews marked this pull request as draft November 21, 2024 01:42
@handrews
Copy link
Member

I approve this, but I can't tell if it needs to go in before or after #4177

@handrews handrews marked this pull request as ready for review November 21, 2024 18:25
@handrews handrews merged commit 56f3c6c into OAI:gh-pages Nov 21, 2024
@ralfhandl ralfhandl deleted the gh-pages-skip-base branch November 21, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants