Port format / integer changes from 3.1.1 #4053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a slightly different change due to the different JSON Schema draft being referenced. Most notably, the older draft has a section on type applicability, so there is an extra link here that is not present in 3.1.1. Co-authored-by: Mike Kistler <[email protected]>
mikekistler
approved these changes
Aug 28, 2024
| Models are defined using the [Schema Object](#schema-object), which is an extended subset of JSON Schema Specification Wright Draft 00. | ||
| Data types in the OAS are based on the non-`null` types supported by the [JSON Schema Validation Specification Draft Wright-00](https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#autoid-32): | ||
| "boolean", "object", "array", "number", "string", or "integer". | ||
| See [`nullable`](#schema-nullable) for an alternative solution to "null" as a type. |
There was a problem hiding this comment.
Oh wow! I totally forgot about "null" when we were working on the 3.0.4 version. We need to exclude null there too, right?
There was a problem hiding this comment.
@mikekistler this is the 3.0.4 version- I did this change backwards (3.1.1 first) because 3.1.1 was easier as it uses JSON Schema as-is. Hopefully I didn't miss anything in this PR where null needed to be removed.
ralfhandl
approved these changes
Aug 28, 2024
ralfhandl
added a commit
to ralfhandl/OpenAPI-Specification
that referenced
this pull request
Aug 28, 2024
1 task
ralfhandl
added a commit
that referenced
this pull request
Aug 28, 2024
…aft-wright-00 3.0.4: use same reference style for draft wright as #4053
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly different change due to the different JSON Schema draft being referenced. Please check it carefully as it would have been easy for me to miss something!
Most notably, the older draft has a section on type applicability, so there is an extra link here that is not present in 3.1.1.