Skip to content

Add format for imf-fixdate used in HTTP headers #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2023

Conversation

mikekistler
Copy link
Contributor

This PR adds a new format for the date-time format used in HTTP headers, as described in RFC 7231, Section 7.1.1.1.

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! As I wasn't familiar with this RFC, I thought maybe a rendered example of a date-time in this format might be beneficial, but I realise we don't have them for most of the other formats (that's my bad, it's missing on the original template).

@mikekistler
Copy link
Contributor Author

I like the suggestion of adding an example so I have done that. I also clarified that this is the preferred format for dates in headers, to match the wording in the RFC.

@MikeRalphson MikeRalphson merged commit 4c5c4be into OAI:gh-pages May 29, 2023
@Saud96525 Saud96525 linked an issue May 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tbarn:coc-enforcement-doc
3 participants