Skip to content

Add Device Code authorization to the supported OAuth Flows #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add Device Code authorization to the supported OAuth Flows #2401

wants to merge 4 commits into from

Conversation

LikeLakers2
Copy link

@LikeLakers2 LikeLakers2 commented Nov 5, 2020

Closes #2381.

This is a PR for the Device Authorization OAuth Flow, based on RFC8628. I suggested this over at #2381 and was asked to make a PR for it.

The URL used for this flow is named deviceAuthorizationUrl, separate from authorizationUrl as the two have completely different semantics and usages, so I was concerned that using authorizationUrl for both might be confusing. That said, I would be happy to merge this into authorizationUrl if requested.

Also, I originally made a comment that this flow may benefit from a optional deviceCodeFormat field. However, I looked at the RFC again, and found that I originally misread the RFC -- the authorization server is the one that creates the code to be used, not the client wanting authorization.

@LikeLakers2
Copy link
Author

LikeLakers2 commented Nov 5, 2020

@MikeRalphson Let me know if those changes I made look good to you. :)

@darrelmiller darrelmiller self-requested a review November 19, 2020 17:18
@webron webron closed this Jul 8, 2021
@webron webron deleted the branch OAI:v3.1.0-dev July 8, 2021 22:02
@MikeRalphson
Copy link
Member

@darrelmiller I was going through the unmerged PRs that were automatically closed when the v3.1.0-dev branch was deleted and I noticed you self-requested a review on this one. Do you feel we should ask @LikeLakers2 to resubmit against v3.2.0-dev?

@LikeLakers2
Copy link
Author

LikeLakers2 commented Jul 21, 2021

I wouldn't mind resubmitting against v3.2.0-dev. I'll wait and see what Darrel says before I do so, though.

@koalo
Copy link

koalo commented Mar 23, 2022

Any updates on this? I am really looking forward to it!

@omz13
Copy link

omz13 commented Jun 28, 2022

I would like to see support for oauth2 device code included. @darrelmiller can you progress this PR or otherwise help?

@webron
Copy link
Member

webron commented Jun 28, 2022

There's probably no harm in filing the PR again against 3.2.0. That said, we might be headed towards a 4.0 version instead (even though it's in very early stages). I think having the PR will keep a reference alive for something that should be looked at.

@LikeLakers2
Copy link
Author

LikeLakers2 commented Jun 29, 2022

@webron I'm unsure if that means you want me to file against 3.2.0. Do you want me to, or would you prefer I wait and see what happens?

In either case, I also want to mention: I have no qualms about someone (whether you, omz13, or someone else) copying and remaking my PR (whether wholesale or edited). So if you feel that might be easier than having me resubmit, then by all means do so.

@webron
Copy link
Member

webron commented Jun 29, 2022

I'm referring to the 3.2.0 dev branch - https://github.com/OAI/OpenAPI-Specification/blob/v3.2.0-dev/versions/3.2.0.md.

To be honest, if we wait and nobody files it, there's a decent chance we'll forget about it because there won't be any active reminder.

@LikeLakers2
Copy link
Author

@webron ...So you want me to resubmit this against the 3.2.0 branch, correct?

@webron
Copy link
Member

webron commented Jun 29, 2022

Yes please.

@LikeLakers2
Copy link
Author

Okay. I will do so soon then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants