Skip to content

Operation Level Tags must be unique, Fix For Issue 1727 #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

r-sreesaran
Copy link

Operation Level Tags must be unique, Fix For Issue 1727

@r-sreesaran
Copy link
Author

@MikeRalphson i have added the changes in 3.1.0 md, have i missed anything else ?.

@MikeRalphson
Copy link
Member

@r-sreesaran No, that LGTM. Unfortunately we ran out of time on the last TSC call to discuss open PRs but we will get to it ASAP.

@earth2marsh
Copy link
Member

Rather than being so strict as to potentially break existing specs, could we add guidance like, "Duplicate tags MAY be considered an authoring mistake"?

@handrews
Copy link
Member

@MikeRalphson

Rather than being so strict as to potentially break existing specs, could we add guidance like, "Duplicate tags MAY be considered an authoring mistake"?

I'm fond of "The behavior of X is undefined" 😛

@r-sreesaran
Copy link
Author

@earth2marsh considering the fact it will break existing code changes, this may be the only way forward.

@darrelmiller darrelmiller added this to the v3.1.0-rc0 milestone Feb 13, 2020
@darrelmiller darrelmiller removed this from the v3.1.0-rc0 milestone Feb 27, 2020
@earth2marsh
Copy link
Member

Based on my rationale in #1727 , I'm inclined to close this issue without merging, though I would also like to recognize the author's contribution to the process--thank you!

@earth2marsh earth2marsh self-requested a review February 27, 2020 17:35
@earth2marsh earth2marsh self-assigned this Feb 27, 2020
@lornajane
Copy link
Contributor

Closing as I don't see a consensus to accept/merge this. I'll second the acknowledgement of the contribution though! Thanks!

@lornajane lornajane closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants