Skip to content

Added required fields #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Added required fields #1051

merged 2 commits into from
Apr 26, 2017

Conversation

webron
Copy link
Member

@webron webron commented Apr 23, 2017

Resolves #962, #963.

Added required url for Server, and content for Request Body.

@webron webron requested a review from darrelmiller April 23, 2017 01:33
@RobDolinMS
Copy link
Contributor

@webron Would you please elaborate on why requestBodyContent is required ?

(I didn't see a clear reason for this in #963)

@whitlockjc
Copy link
Member

I'm with @RobDolinMS, I'd like to understand why requestBodyContent is required.

@webron
Copy link
Member Author

webron commented Apr 25, 2017

The Request Body Object currently has no required fields. That means you can specify a request body without specifying anything. That has no semantic meaning. If you define a request body, you should define what it represents. Even if it's any value, it should be specified, meaning, you have to have content in it.

@whitlockjc
Copy link
Member

:shipit:

After talking with @webron about this offline, it makes sense to me now.

@webron webron merged commit 4c2f701 into OpenAPI.next Apr 26, 2017
@webron webron deleted the requireed-fields branch April 26, 2017 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants