Skip to content

fix: invalid isa pointer access in ios 14 #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2020

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Jul 1, 2020

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot
Copy link

cla-bot bot commented Jul 1, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @rigor789.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@rigor789
Copy link
Member Author

rigor789 commented Jul 1, 2020

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jul 1, 2020
@cla-bot
Copy link

cla-bot bot commented Jul 1, 2020

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@NathanWalker NathanWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed works on iOS 14

@rigor789 rigor789 requested a review from mbektchiev July 3, 2020 15:36
Copy link
Contributor

@mbektchiev mbektchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@rigor789 rigor789 added this to the 6.5.2 milestone Jul 9, 2020
@rigor789 rigor789 added the bug label Jul 9, 2020
@rigor789 rigor789 merged commit 922ee51 into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants