fix(metadata-generator): Typings generation of global functions #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encode functions' args as params.
mbektchiev
force-pushed
the
bektchiev/fix-mdg-dts-blocks-funcs
branch
from
582e069 to
745df9f
Compare
mbektchiev
changed the title
vtrifonov
approved these changes
Feb 10, 2020
mbektchiev
changed the title
mbektchiev
added a commit
to NativeScript/NativeScript
that referenced
this pull request
Mar 12, 2020
This fixes arguments of global functions. See NativeScript/ios-jsc#1250
5 tasks
mbektchiev
added a commit
to NativeScript/NativeScript
that referenced
this pull request
Mar 12, 2020
This fixes arguments of global functions. See NativeScript/ios-jsc#1250
mbektchiev
added a commit
to NativeScript/NativeScript
that referenced
this pull request
Mar 13, 2020
* chore: Update typings using iOS SDK 13.2 (Xcode 11.3.1) * chore: Update iOS typings using the latest runtime This fixes arguments of global functions. See NativeScript/ios-jsc#1250 * chore: Strip MDC types attached to other modules * Delete via regex from generation script * Apply regex to current typings
NathanWalker
pushed a commit
to NativeScript/NativeScript
that referenced
this pull request
Aug 7, 2020
* chore: Update typings using iOS SDK 13.2 (Xcode 11.3.1) * chore: Update iOS typings using the latest runtime This fixes arguments of global functions. See NativeScript/ios-jsc#1250 * chore: Strip MDC types attached to other modules * Delete via regex from generation script * Apply regex to current typings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode functions' args as params.
PR Checklist
#1022 actually missed applying this strategy to global C functions
After merging it we need to regenerate typings in
tns-platform-declarations.