Skip to content

fix: don't crash app if flag is present #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

DickSmith
Copy link
Contributor

PR Checklist

What is the current behaviour?

App will crash.

What is the new behaviour?

App will shutdown.

@cla-bot cla-bot bot added the cla: yes label Nov 24, 2019
@DickSmith DickSmith changed the title fix: it's called reportFatalErrorBeforeShutdown; not reportFatalErrorBeforeCrash fix: don't cascade crash app if flag is present Nov 24, 2019
@DickSmith DickSmith changed the title fix: don't cascade crash app if flag is present fix: don't crash app if flag is present Nov 24, 2019
Copy link
Contributor

@mbektchiev mbektchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DickSmith, thank you for the PR! It generally looks good, I'd like you to address the comment and warn you that exiting instead of throwing an exception could mean that automatic exception reporting by Crashlitics could be hindered. The uncaught JS error handler, however, will get called. So if an app has logic for reporting errors there (which is always a good idea), this shouldn't be an issue.

@mbektchiev
Copy link
Contributor

run ci

@mbektchiev mbektchiev self-assigned this Nov 28, 2019
@mbektchiev mbektchiev added this to the 6.3.0 milestone Nov 28, 2019
@mbektchiev mbektchiev merged commit a744ddb into NativeScript:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants