fix(runtime): Do not hide property with more accessors #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbektchiev
force-pushed
the
bektchiev/fix-readonly-property-from-protocol
branch
2 times, most recently
from
25f4e6d to
f140fab
Compare
vmutafov
approved these changes
Nov 13, 2019
A property can be defined from both a protocol and a base class. Currently if it is in a protocol it takes precedence but there are cases which the other way around would be preferable. * (ObjCPrototype) Check for property descriptor of base class and return that we don't define it if the base one has more accessors. * (ObjCClassBuilder) When defining a property check for metadata with and without considering protocols. Use the one with more accessors. * Add unit tests
mbektchiev
force-pushed
the
bektchiev/fix-readonly-property-from-protocol
branch
from
f140fab to
3c3b083
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A property can be defined from both a protocol and a base class.
Currently, the protocol definition takes precedence but there are
cases in which the other way around is correct.
don't define it if the base one has more accessors.
with and without considering protocols. Use the one with more accessors.
PR Checklist
refs #1223