Skip to content

fix(project-template): Remove build scripts from target #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

mbektchiev
Copy link
Contributor

@mbektchiev mbektchiev commented Nov 11, 2019

Otherwise, they ended up being included in the app bundle.

The following files have been removed from the app target in the project template:

  • nativescript-pre-build
  • nativescript-post-build
  • nativescript-pre-link
  • strip-dynamic-framework-architectures.sh
  • nsld.sh

PR Checklist

Note To avoid regressing this, we should add integration tests that verify that no unexpected files appear in the built app bundles!

@mbektchiev mbektchiev added this to the 6.3.0 milestone Nov 11, 2019
@mbektchiev mbektchiev self-assigned this Nov 11, 2019
@cla-bot cla-bot bot added the cla: yes label Nov 11, 2019
Otherwise they ended up being included in the app bundle.
@mbektchiev mbektchiev force-pushed the bektchiev/remove-build-scripts-from-ipa branch from 7499541 to c0e0727 Compare November 11, 2019 10:18
@mbektchiev mbektchiev merged commit 7beb5dc into master Nov 13, 2019
@mbektchiev mbektchiev deleted the bektchiev/remove-build-scripts-from-ipa branch November 13, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants