Skip to content

Update WebKit to 13.2 #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 5, 2019
Merged

Update WebKit to 13.2 #1220

merged 14 commits into from
Dec 5, 2019

Conversation

mbektchiev
Copy link
Contributor

@mbektchiev mbektchiev commented Nov 5, 2019

PR Checklist

* Add 2nd template argument to `subspaceFor` methods
* Add new methods of inspector backend dispatchers
* Use `mapIteratorStructure()` getter
* Add missing enum cases of switches
* Remove call to deleted clearNumParametersForCall
(should be unnecessary now)
* `ownerScriptExecutable` -> `ownerExecutable`
* Remove deleted include `JSSegmentedVariableObjectHeapCellType.h`
* `atomicStringTable` -> `atomStringTable`
* Add `hasIsReleasedWeakValueFunction`
* Change C++ standard to gnu++17
* Comment calls to removed `programmaticCapture...` functions
* Add dummy case for `Inspector::Protocol::Timeline::Instrument::CPU`
@cla-bot cla-bot bot added the cla: yes label Nov 5, 2019
* Make pointer's hex string lowercase
* Change `console.time`'s log level to `info`
These options have been introduced with:
NativeScript/webkit@b9d4168
And lost during conflict resolution when merging verson `ios-13.1.3`

`JSC_OBJC_API_ENABLED` being true by default led to the following
warnings at run time:
`Class JSContext is implemented in both JavaScriptCore.framework/JavaScriptCore (0x7fff87ce2900) and NativeScript.framework/NativeScript (0x1114e9ec8). One of the two will be used. Which one is undefined.`
@Natalia-Hristova
Copy link

test --performance-only

* Add stubs in `InspectorFrontendHostStub.h`  for the new functions
in `InspectorFrontendHost.h`
* Update `InspectorBackendCommands.js` from
`Legacy/13.0/InspectorBackendCommands.js` and do not activate
domains which are unsupported by {N}
@mbektchiev mbektchiev marked this pull request as ready for review December 4, 2019 13:10
@mbektchiev mbektchiev changed the title WIP: Update WebKit to 13.2 Update WebKit to 13.2 Dec 4, 2019
* Delete commented code
* Delete unused WebKit2 directory
@mbektchiev
Copy link
Contributor Author

test --performance

@mbektchiev mbektchiev merged commit 56fad7d into master Dec 5, 2019
@mbektchiev mbektchiev deleted the bektchiev/webkit-13 branch December 5, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants