fix(runtime): Lookup into native MD tables when searching by name #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Querying metadata for Objective-C interfaces and protocols should not be done by the JS name when the string we search for is actually their native name * Introduce 2 additional global tables in metadata for Interface and Protocols by indexed by their native name * Make `Metadata::GlobalTable` a template struct and move its implementation to `MetadataInlines.h` * Use the correct global table depending on the name and entity being looked up * Add unit test with an `objc_runtime_name` attribute emulating that it's been generated by the Swift compiler
vmutafov
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying metadata for Objective-C interfaces and protocols should
not be done by the JS name when the string we search for is actually
their native name
indexed by their native name
Metadata::GlobalTablea template struct and move its implementationto
MetadataInlines.hobjc_runtime_nameattribute emulating that it's beengenerated by the Swift compiler
PR Checklist
refs #712