Skip to content

fix(inspector): Conditional breakpoints by Chrome DevTools frontend #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2019
Merged

fix(inspector): Conditional breakpoints by Chrome DevTools frontend #1215

merged 1 commit into from
Oct 22, 2019

Conversation

mbektchiev
Copy link
Contributor

Chrome DevTools protocol is slightly different and sets conditional breakpoints'
condition via a top-level condition property instead of in options

refs #1181

PR Checklist

@mbektchiev
fix(inspector): Conditional breakpoints by Chrome DevTools frontend
4982e9c 
Chrome DevTools protocol is slightly different and sets conditional breakpoints'
condition via a top-level `condition` property instead of in `options`
@mbektchiev mbektchiev added the bug label Oct 21, 2019
@mbektchiev mbektchiev added this to the 6.3.0 milestone Oct 21, 2019
@mbektchiev mbektchiev self-assigned this Oct 21, 2019
@cla-bot cla-bot bot added the cla: yes label Oct 21, 2019
@vtrifonov vtrifonov merged commit ae3cb42 into master Oct 22, 2019
@vtrifonov vtrifonov deleted the bektchiev/fix-conditional-breakpoints branch October 22, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtrifonov vtrifonov vtrifonov approved these changes

@darind darind Awaiting requested review from darind

@vmutafov vmutafov Awaiting requested review from vmutafov

Assignees

@mbektchiev mbektchiev

Labels
bug cla: yes
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mbektchiev @vtrifonov