Skip to content

cuda.core: CUResult, cudaError explanations #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 26, 2025

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Mar 8, 2025

Closes #198

Produce more informative error messages than what the driver or runtime libraries have built in.

Copy link
Contributor

copy-pr-bot bot commented Mar 8, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk
Copy link
Collaborator Author

rwgk commented Mar 8, 2025

/ok to test

This comment has been minimized.

@rwgk rwgk changed the title [WIP] cuda.core: CUResult, cudaError explanations cuda.core: CUResult, cudaError explanations Mar 8, 2025
@rwgk rwgk marked this pull request as ready for review March 8, 2025 19:42
Copy link
Contributor

copy-pr-bot bot commented Mar 8, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk requested a review from leofang March 8, 2025 19:42
@leofang leofang added this to the cuda.core beta 4 milestone Mar 9, 2025
@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.core Everything related to the cuda.core module labels Mar 9, 2025
@rwgk
Copy link
Collaborator Author

rwgk commented Mar 10, 2025

/ok to test

@rwgk rwgk requested a review from ksimpson-work March 11, 2025 19:04
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally really like it. Hopefully we can revert it all one day if error messages improve from upstream in the callstack. Will approve after code freeze :)

@rwgk
Copy link
Collaborator Author

rwgk commented Mar 17, 2025

/ok to test

@rwgk
Copy link
Collaborator Author

rwgk commented Mar 26, 2025

/ok to test

@rwgk
Copy link
Collaborator Author

rwgk commented Mar 26, 2025

I freshly updated this PR (git merge main).

@ksimpson-work or @leofang, could someone please approve?

@rwgk rwgk merged commit 73fa3c0 into NVIDIA:main Mar 26, 2025
74 checks passed
@rwgk rwgk deleted the error_explanations branch March 26, 2025 17:31
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang
Copy link
Member

leofang commented Mar 26, 2025

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module feature New feature or request P0 High priority - Must do!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make error messages more clear and actionable
4 participants