Skip to content

[Backport] Enable discovery and loading at run time of NVRTC and nvJitLink libraries in a wheels ecosystem #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2025
Merged

[Backport] Enable discovery and loading at run time of NVRTC and nvJitLink libraries in a wheels ecosystem #369

merged 3 commits into from
Jan 9, 2025

Conversation

@vzhurba01
Copy link
Contributor

@vzhurba01 vzhurba01 commented Jan 9, 2025

No description provided.

@vzhurba01
Support discovery of nvrtc libraries at run time
1f4d738 
CTK installations distribute their libraries using personal packages:
- nvidia-cuda-nvrtc-cuXX

The relative path of their libraries to cuda-bindings is consistent,
and allows us to use relative paths to discover them when loading
at run time.
@vzhurba01
Fix check
d4ad29f
@vzhurba01 vzhurba01 added enhancement Any code-related improvements P0 High priority - Must do! packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module labels Jan 9, 2025
@vzhurba01 vzhurba01 added this to the cuda-python 12-next, 11-next milestone Jan 9, 2025
@vzhurba01 vzhurba01 self-assigned this Jan 9, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01
Copy link
Contributor Author

vzhurba01 commented Jan 9, 2025

/ok to test

@leofang leofang mentioned this pull request Jan 9, 2025
Merged
leofang
leofang approved these changes Jan 9, 2025
View reviewed changes
@leofang
Copy link
Member

leofang commented Jan 9, 2025 •
edited
Loading

I'll backport #368 once it's merged. We should get this PR merged first to make it green.

@vzhurba01 vzhurba01 merged commit a20f0f4 into NVIDIA:11.8.x Jan 9, 2025
@vzhurba01
Copy link
Contributor Author

vzhurba01 commented Jan 9, 2025

Merging. Thanks!

@leofang
Copy link
Member

leofang commented Jan 9, 2025

All tests failed? https://github.com/NVIDIA/cuda-python/actions/runs/12695755926

@leofang leofang mentioned this pull request Jan 10, 2025
Merged
leofang
leofang reviewed Jan 10, 2025
View reviewed changes
@leofang leofang changed the title Backport 363 to 11.8.x [Backport] Enable discovery and loading at run time of NVRTC and nvJitLink libraries in a wheels ecosystem Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofang leofang leofang approved these changes

Assignees

@vzhurba01 vzhurba01

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do! packaging Anything related to wheels or Conda packages

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

2 participants

@vzhurba01 @leofang