Remove versioneer to instead manually bump version #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhurba01
added
P0
|
/ok to test |
vzhurba01
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
|
/ok to test |
|
/ok to test |
vzhurba01
changed the title
leofang
added
the
to-be-backported
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 11.8.x
git worktree add -d .worktree/backport-307-to-11.8.x origin/11.8.x
cd .worktree/backport-307-to-11.8.x
git switch --create backport-307-to-11.8.x
git cherry-pick -x 0dd741ec4adf7e1a5eff3b481900dec6f009cef1 e58e2f4a924f9f5b28f6edcf899ef113ad24f39d bfa2bc6df45216f41ae97d91612db54418c6edba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #233.
Use manually bump'd versions instead of a versions produced through git tags. Many alternatives to versioneer leverage git tags but that style of approach is incompatible with cuda-python's current development workflow.
Furthermore, using manual version bumps for cuda.bindings would also align with cuda.core. Since both sub-packages have independent release cadence, manual version bumps prevent these two packages from stepping on each other toes when a new release tag for either project is created.