Skip to content

add nvjitlink to bindings documentation #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 18, 2024

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Dec 12, 2024

close #251

Add the nvjitlink rst.

There are some formatting issues tracked internally that I plan to address. See the docstring for version() Return

@ksimpson-work ksimpson-work added documentation Improvements or additions to documentation cuda.bindings Everything related to the cuda.bindings module labels Dec 12, 2024
@ksimpson-work ksimpson-work self-assigned this Dec 12, 2024
Copy link
Contributor

copy-pr-bot bot commented Dec 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work ksimpson-work marked this pull request as ready for review December 12, 2024 18:57
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Dec 12, 2024
@leofang leofang added the P1 Medium priority - Should do label Dec 12, 2024
@leofang leofang linked an issue Dec 13, 2024 that may be closed by this pull request
vzhurba01
vzhurba01 previously approved these changes Dec 13, 2024
Copy link
Collaborator

@vzhurba01 vzhurba01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw we need to also add a release note entry (#251 (comment))

@ksimpson-work
Copy link
Contributor Author

I've added notes to 12.8 release which is what I think I heard in yesterday's meeting. I am starting to understand the release versions and cadence etc. Until recently I did not ever take it into consideration (last project was CTK version agnostic)

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Keenan! Let's merge!

@leofang leofang merged commit 33b7366 into NVIDIA:main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P1 Medium priority - Should do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend github.io documentation with nvJitLink API references
3 participants