Skip to content

Fix build and remove some unused code. #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

sandeepd-nv
Copy link
Member

No description provided.

@sandeepd-nv sandeepd-nv force-pushed the ksimpson/fix-gh-actions branch from bc8ab76 to 42785b4 Compare November 20, 2024 04:15
Copy link
Contributor

copy-pr-bot bot commented Nov 20, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sandeep-datta
Copy link

/ok to test

@leofang
Copy link
Member

leofang commented Nov 26, 2024

Thanks, Sandeep. Could you also take this opportunity and move everything under continuous_integration to .github/, and the nuke the former? From a repo hygiene perspective it is weird that we have a non-user-folder at the root directory that has the longest name...

@leofang
Copy link
Member

leofang commented Nov 26, 2024

It seems there are two commits from this PR cherry-picked into #249, but the remaining ones are not?

@ksimpson-work
Copy link
Contributor

ksimpson-work commented Nov 26, 2024

Yeah @sandeepd-nv made this PR and requested I merge it with the one I submitted for the build CI. I just cherry picked the commits which were relevant. I think this PR is stale and can be deleted

@sandeepd-nv sandeepd-nv closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants