-
Notifications
You must be signed in to change notification settings - Fork 158
update the nvjitlink bindings test #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kenan! Glad we figure out how to test it robustly. I left a few comments.
leofang
requested changes
Nov 26, 2024
2b1353a
to
3ed20a8
Compare
btw the Ruff PR was in, let's also resolve the conflicts (and re-run Ruff locally) |
4fd226c
to
93b495f
Compare
/ok to test |
leofang
approved these changes
Nov 28, 2024
Merging, thanks @ksimpson-work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cuda.bindings
Everything related to the cuda.bindings module
P1
Medium priority - Should do
test
Improvements or additions to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the ptx test. Was previously TODO
(cuda_py) ksimpson@NV-3KWHSV3:~/cuda-python/cuda-python/cuda_bindings/tests$ python -m pytest test_nvjitlink.py
=================================================================== test session starts ====================================================================
platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /home/ksimpson/cuda-python/cuda-python/cuda_bindings
configfile: pyproject.toml
plugins: benchmark-4.0.0
collected 11 items
test_nvjitlink.py ........... [100%]