Skip to content

update the nvjitlink bindings test #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Nov 8, 2024

add the ptx test. Was previously TODO

(cuda_py) ksimpson@NV-3KWHSV3:~/cuda-python/cuda-python/cuda_bindings/tests$ python -m pytest test_nvjitlink.py
=================================================================== test session starts ====================================================================
platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /home/ksimpson/cuda-python/cuda-python/cuda_bindings
configfile: pyproject.toml
plugins: benchmark-4.0.0
collected 11 items

test_nvjitlink.py ........... [100%]

Copy link
Contributor

copy-pr-bot bot commented Nov 8, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kenan! Glad we figure out how to test it robustly. I left a few comments.

@leofang leofang added P1 Medium priority - Should do test Improvements or additions to tests cuda.bindings Everything related to the cuda.bindings module labels Nov 12, 2024
@leofang leofang added this to the cuda.core beta 2 milestone Nov 12, 2024
@ksimpson-work ksimpson-work force-pushed the ksimpson/update_nvjitlink_test branch from 2b1353a to 3ed20a8 Compare November 26, 2024 18:19
@leofang
Copy link
Member

leofang commented Nov 27, 2024

btw the Ruff PR was in, let's also resolve the conflicts (and re-run Ruff locally)

@ksimpson-work ksimpson-work force-pushed the ksimpson/update_nvjitlink_test branch from 4fd226c to 93b495f Compare November 27, 2024 20:07
@leofang
Copy link
Member

leofang commented Nov 28, 2024

/ok to test

@leofang
Copy link
Member

leofang commented Nov 28, 2024

Merging, thanks @ksimpson-work!

@leofang leofang merged commit fd71ced into main Nov 28, 2024
1 check passed
@leofang leofang deleted the ksimpson/update_nvjitlink_test branch November 28, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do test Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants