Skip to content

Clean up testsuite #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 18, 2024
Merged

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Nov 4, 2024

Clean up the testsuite by:

  1. Removing calls to internal entry-points in favour of public ones.
  2. Updating the use of fixtures to handle context initialization on a per-test basis. This includes a function level fixture to init, and then subsequently de-init when calling a method which requirts context initalization (usually via device.set_current()). It also includes a fixture to deinit after some tests which call set_current() as part of their logic.
  3. As an effect of moving to public entry-points, the tests become more relational. The use of examples as additional tests also increases relational test coverage'

closes #196

Copy link
Contributor

copy-pr-bot bot commented Nov 4, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work ksimpson-work marked this pull request as ready for review November 4, 2024 19:22
@leofang leofang assigned leofang and ksimpson-work and unassigned leofang Nov 15, 2024
@leofang leofang added P0 High priority - Must do! test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Nov 15, 2024
@leofang leofang added this to the cuda.core beta 2 milestone Nov 15, 2024
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Keenan, left some nits.

@ksimpson-work
Copy link
Contributor Author

Thanks @leofang for those comments. I addressed all of them and made the changes.

leofang
leofang previously approved these changes Nov 16, 2024
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Keenan! Left 3 nits, feel free to merge after addressing them.

@ksimpson-work ksimpson-work merged commit e36241a into main Nov 18, 2024
@ksimpson-work ksimpson-work deleted the ksimpson/public_entrypoint_testing_196 branch November 18, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module P0 High priority - Must do! test Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure only public entry points are used in tests
3 participants