Skip to content

Fix Stream.device and Stream.context with respect to _util.device.from_ctx #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ksimpson-work opened this issue Oct 30, 2024 · 0 comments · Fixed by #203
Closed

Fix Stream.device and Stream.context with respect to _util.device.from_ctx #202

ksimpson-work opened this issue Oct 30, 2024 · 0 comments · Fixed by #203
Assignees
Labels
bug Something isn't working cuda.core Everything related to the cuda.core module P1 Medium priority - Should do

Comments

@ksimpson-work
Copy link
Contributor

The obvious issue is that both of these call get_device_from_ctx which references the unimported Device(). Importing it would cause a circular dependency. This does not appear to be the root of the issue, as per the logic of the Stream class, and the cuda model, self._device_id can never be None. In short, we can get rid of util.device_from_ctx

@ksimpson-work ksimpson-work added cuda.core Everything related to the cuda.core module P1 Medium priority - Should do labels Oct 30, 2024
@ksimpson-work ksimpson-work self-assigned this Oct 30, 2024
@leofang leofang added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda.core Everything related to the cuda.core module P1 Medium priority - Should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants