-
Couldn't load subscription status.
- Fork 552
chore(types): Type-clean /actions_server (3 errors) #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(types): Type-clean /actions_server (3 errors) #1379
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore/type-clean-guardrails #1379 +/- ##
============================================================
Coverage 71.62% 71.63%
============================================================
Files 171 171
Lines 17020 17023 +3
============================================================
+ Hits 12191 12194 +3
Misses 4829 4829
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Tagging @cparisien , @Pouyanpi , @trebedea for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cleaner! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Tim 👍🏻
Description
Only a few type-cleaning steps to add the actions server as a FastAPI Dependency to inject it into endpoint methods, rather than an attribute on the Fast API server. Also some logging cleanups (%s, not f-strings)
Test plan
Type-checking
Unit-tests
Action-server local test
Server-side
Client-side
Related Issue(s)
Top-level PR to combine all type-fixes into a single merge-to-develop: #1367
Checklist