Skip to content

fix #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2020
Merged

fix #129

merged 2 commits into from
Oct 22, 2020

Conversation

arpir
Copy link
Contributor

@arpir arpir commented Oct 22, 2020 •
edited
Loading

  1. Fix the bowser warnings about dangerous & deceptive content
  2. fix the open link display when html's name is too long,it wiil be hidden.

arpir added 2 commits October 22, 2020 11:05
@arpir
fix
9e4259a 
1. Support child folder html file preview 
2. Fix the bowser warnings about dangerous & deceptive content
@arpir
Update github-html-preview.user.js
25c205e
@Mottie
Copy link
Owner

Mottie commented Oct 22, 2020

Thanks!!

@Mottie Mottie merged commit d8edd05 into Mottie:master Oct 22, 2020
@Mottie
Copy link
Owner

Mottie commented Oct 22, 2020

I commited a change to prepend the preview link to the file name since I didn't like the links on the separate lines. I hope it isn't too far off from what you are trying to do. Thanks again!

@arpir
Copy link
Contributor Author

arpir commented Oct 23, 2020

I commited a change to prepend the preview link to the file name since I didn't like the links on the separate lines. I hope it isn't too far off from what you are trying to do. Thanks again!

yeah , i just found the problem .I agree to your solution,it is great and better!!

@arpir
Copy link
Contributor Author

arpir commented Oct 23, 2020

I commited a change to prepend the preview link to the file name since I didn't like the links on the separate lines. I hope it isn't too far off from what you are trying to do. Thanks again!

May the links display 14px better? 12px seems small ?

Mottie added a commit that referenced this pull request Oct 24, 2020
@Mottie
Html-preview: Increase external link icon to 14px. See #129
8665643
@Mottie
Copy link
Owner

Mottie commented Oct 24, 2020

May the links display 14px better? 12px seems small ?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpir @Mottie